Mark candidate trial in the legends for Arm Effects and Scatter Plot (1/2) #4219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855536 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 28, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Differential Revision: D79855536
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
==========================================
- Coverage 96.12% 96.12% -0.01%
==========================================
Files 566 566
Lines 57445 57465 +20
==========================================
+ Hits 55220 55237 +17
- Misses 2225 2228 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Differential Revision: D79855536
shrutipatel31
force-pushed
the
export-D79855536
branch
from
3ea7cb4 to
89bfd2e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855536 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: Pull Request resolved: facebook#4219 This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Differential Revision: D79855536
shrutipatel31
force-pushed
the
export-D79855536
branch
from
89bfd2e to
1923fdf
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Differential Revision: D79855536
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
shrutipatel31
force-pushed
the
export-D79855536
branch
from
1923fdf to
6ad4137
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855536 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
shrutipatel31
force-pushed
the
export-D79855536
branch
from
6ad4137 to
89f9faa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855536 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: Pull Request resolved: facebook#4219 This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
shrutipatel31
force-pushed
the
export-D79855536
branch
from
89f9faa to
31966a9
Compare
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
shrutipatel31
force-pushed
the
export-D79855536
branch
from
31966a9 to
b8f7c25
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855536 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
Contributor
|
This pull request has been merged in a499a77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library.
The changes include -
Differential Revision: D79855536