-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop jsonfield dependency and use builtin JSONField #180
fix: drop jsonfield dependency and use builtin JSONField #180
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 85.41% 85.34% -0.07%
==========================================
Files 21 21
Lines 432 430 -2
==========================================
- Hits 369 367 -2
Misses 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
extra_settings/migrations/0005_setting_value_json_alter_setting_value_type.py
Outdated
Show resolved
Hide resolved
@obdulia-losantos thank you for this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obdulia-losantos thank you for this PR, general considerations:
- keep
django
inrequirements.txt
but not inpyproject.toml
- don't remove
requirements.txt
file - completely remove third-party JSONField dependency and references
- don't add unnecessary migrations
@fabiocaccamo I applied your suggestions but this is the error I have and the reason of deleting the file |
@obdulia-losantos don't worry about the Codacy issue, the important thing is that it passes all the tests. Perfect, thank you! |
name: Drop jsonfield
about: Drops jsonfield dependency
assignees: fabiocaccamo
Describe your changes
Dropped unmaintained
jsonfield
field and replacedjsonfield.JSONField
withdjango.db.models.JSONField
class.Addresses second option indicated in PR #179
Related issue
#178
Checklist before requesting a review