fix: drop jsonfield and use builtin JSONField #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obdulia-losantos
force-pushed
the
fix-json-field
branch
2 times, most recently
from
fcf8a40 to
c16bf52
Compare
obdulia-losantos
force-pushed
the
fix-json-field
branch
from
c16bf52 to
63bf50e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 85.41% 85.77% +0.36%
==========================================
Files 21 23 +2
Lines 432 443 +11
==========================================
+ Hits 369 380 +11
Misses 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Drop jsonfield
about: Replace
jsonfield.JSONFieldwithdjango.db.models.JSONFieldclassassignees: fabiocaccamo
Describe your changes
Dropped unmaintained
jsonfieldfield and replacedjsonfield.JSONFieldwithdjango.db.models.JSONFieldclass.The dependency cannot be removed because is used within a migration file. I have squashed the migration files so maybe in the future it can be removed.
Another solution is to change the migration file and replace jsonfield with django field.
🤷 See PR #180
Related issue
#178
Checklist before requesting a review