Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Change GGN to purely PyTorch #146

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[ADD] Change GGN to purely PyTorch #146

wants to merge 14 commits into from

Conversation

f-dangel
Copy link
Owner

Only review after #142, #145.

@f-dangel f-dangel marked this pull request as draft October 27, 2024 16:19
This was referenced Oct 27, 2024
Draft
Draft
Draft
Draft
@f-dangel f-dangel marked this pull request as ready for review November 4, 2024 18:41
@f-dangel f-dangel requested a review from runame November 4, 2024 18:41
@f-dangel
Copy link
Owner Author

f-dangel commented Nov 4, 2024

Ready for review.

@coveralls
Copy link

coveralls commented Nov 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11670932829

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 3 files are covered.
  • 56 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.3%) to 88.596%
Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/_torch_base.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
curvlinops/examples/utils.py 10 31.25%
curvlinops/fisher.py 46 26.47%
Totals Coverage Status
Change from base Build 11670495773: -3.3%
Covered Lines: 1515
Relevant Lines: 1710
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame Awaiting requested review from runame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Linear operators for PyTorch and SciPy
Development

Successfully merging this pull request may close these issues.
2 participants
@f-dangel @coveralls