Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Change Hessian to purely PyTorch #145

Merged
merged 10 commits into from
Nov 4, 2024
Merged

[ADD] Change Hessian to purely PyTorch #145

merged 10 commits into from
Nov 4, 2024

Conversation

f-dangel
Copy link
Owner

Only review after #142

@f-dangel f-dangel marked this pull request as draft October 27, 2024 16:17
This was referenced Oct 27, 2024
Open
Draft
Draft
Draft
Draft
@f-dangel f-dangel marked this pull request as ready for review November 4, 2024 15:46
@f-dangel f-dangel requested a review from runame November 4, 2024 15:46
@f-dangel
Copy link
Owner Author

f-dangel commented Nov 4, 2024

Ready for review.

@coveralls
Copy link

coveralls commented Nov 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11670381568

Details

  • 11 of 16 (68.75%) changed or added relevant lines in 2 files are covered.
  • 59 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.1%) to 88.61%
Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/utils.py 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
curvlinops/_base.py 3 84.4%
curvlinops/examples/utils.py 10 31.25%
curvlinops/fisher.py 46 26.47%
Totals Coverage Status
Change from base Build 11667562849: -1.1%
Covered Lines: 1517
Relevant Lines: 1712
💛 - Coveralls

runame
runame approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just confused about only considering the block-diagonal case.

test/test_hessian.py Show resolved Hide resolved
@f-dangel f-dangel merged commit 5e118e9 into main Nov 4, 2024
13 checks passed
@f-dangel f-dangel deleted the hessian-linop branch November 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Linear operators for PyTorch and SciPy
Development

Successfully merging this pull request may close these issues.
3 participants
@f-dangel @coveralls @runame