chore: init config for changeset#44
Merged
Crunchyman-ralph merged 2 commits intonextfrom Mar 28, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: cef451b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
eyaltoledano
added a commit
that referenced
this pull request
Nov 29, 2025
…logic Address PR #1452 review comments from Crunchyman-ralph: - Add AUTH_TIMEOUT_MS and MFA_MAX_ATTEMPTS constants to @tm/core - Create shared auth-ui.ts with AuthCountdownTimer class and MFA utilities - Refactor auth-guard.ts to use shared utilities (reduced duplication) - Refactor auth.command.ts to use shared utilities and expose methods - Simplify login.command.ts to delegate to AuthCommand (341→50 lines) - Simplify logout.command.ts to delegate to AuthCommand (76→45 lines) - Convert dynamic imports to static imports in scripts/init.js - Convert dynamic import to static import in scripts/modules/ui.js Fixes: #31, #32, #33, #17, #18, #44, #53 from PR review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing these changes
What are these changes doing
How will the flows change from now on?