Conversation
- Fix tests using ES Module best practices instead of complex mocking - Replace Commander.js mocking with direct action handler testing - Resolve ES Module import/mock issues and function redeclaration errors - Fix circular reference issues with console.log spies - Properly setup mock functions with jest.fn() for method access - Improve parse-prd command functionality - Add default PRD path support (scripts/prd.txt) so you can just run `task-master parse-prd` and it will use the default PRD if it exists. - Improve error handling and user feedback - Enhance help text with more detailed information - Fix detectCamelCaseFlags implementation in utils.js yet again with more tests this time - Improve regex pattern to correctly detect camelCase flags - Skip flags already in kebab-case format - Enhance tests with proper test-specific implementations - Document testing best practices - Add comprehensive "Common Testing Pitfalls and Solutions" section to tests.mdc - Provide clear examples of correct testing patterns for ES modules - Document techniques for test isolation and mock organization
Fix issue with kebab-case validator incorrectly flagging single-word flags like --prompt. Refactor detectCamelCaseFlags to properly handle all single-word flags. Update tests to verify correct behavior with single-word and camelCase flags. Add support for alternative flag formats in init command (e.g., -my_name). This fixes a bug where users couldn't use the --prompt flag directly and had to use -p instead.
…djust based on the longest string in the column. But that's an overoptimization for now.
… rules we currently package, and has been edited to be Windsurf specific. Rules are added in as sections. The init function will search for an existing .windsurfrules document, and if it finds it, it will append to it. Otherwise it will create it.
eyaltoledano
added
bug
ProdByBuddha
pushed a commit
to ProdByBuddha/claude-task-master
that referenced
this pull request
Apr 9, 2025
Parse prd defaults
eyaltoledano
added a commit
that referenced
this pull request
Nov 29, 2025
…logic Address PR #1452 review comments from Crunchyman-ralph: - Add AUTH_TIMEOUT_MS and MFA_MAX_ATTEMPTS constants to @tm/core - Create shared auth-ui.ts with AuthCountdownTimer class and MFA utilities - Refactor auth-guard.ts to use shared utilities (reduced duplication) - Refactor auth.command.ts to use shared utilities and expose methods - Simplify login.command.ts to delegate to AuthCommand (341→50 lines) - Simplify logout.command.ts to delegate to AuthCommand (76→45 lines) - Convert dynamic imports to static imports in scripts/init.js - Convert dynamic import to static import in scripts/modules/ui.js Fixes: #31, #32, #33, #17, #18, #44, #53 from PR review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds .windsurfrules to the init package. It's composed of the 3 rules we currently package, and has been edited to be Windsurf specific. Rules are added in as sections. The init function will search for an existing .windsurfrules document, and if it finds it, it will append to it. Otherwise it will create it.
Fix tests using ES Module best practices instead of complex mocking
Improve parse-prd command functionality
task-master parse-prdand it will use the default PRD if it exists.Fix detectCamelCaseFlags implementation in utils.js yet again with more tests this time
Document testing best practices
Fix issue with kebab-case validator incorrectly flagging single-word flags like --prompt.
Refactor detectCamelCaseFlags to properly handle all single-word flags. Update tests to verify correct behavior with single-word and camelCase flags.
Add support for alternative flag formats in init command (e.g., -my_name). This fixes a bug where users couldn't use the --prompt flag directly and had to use -p instead.
Adds and marks tasks 30 and 31 as done.
Closes #29
Closes #3