(test): fixing tests node v18

.github/workflows/ci.yml

@@ -6,7 +6,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         name:
@@ -222,4 +222,4 @@ jobs:
       uses: coverallsapp/github-action@master
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
-        parallel-finished: true
+        parallel-finished: true

README.md

@@ -14,7 +14,7 @@ This is a [Node.js](https://nodejs.org/en/) module available through the
 [npm registry](https://www.npmjs.com/). Installation is done using the
 [`npm install` command](https://docs.npmjs.com/getting-started/installing-npm-packages-locally):
 
-```sh
+```
 $ npm install serve-index
 ```
 

eslint.config.mjs

@@ -0,0 +1,44 @@
+import { defineConfig, globalIgnores } from "eslint/config";
+import markdown from "eslint-plugin-markdown";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all
+});
+
+export default defineConfig([globalIgnores(["**/.nyc_output", "**/coverage", "**/node_modules"]), {
+  extends: compat.extends("plugin:markdown/recommended"),
+
+  plugins: {
+    markdown,
+  },
+
+  rules: {
+    "eol-last": "error",
+    eqeqeq: ["error", "allow-null"],
+
+    indent: ["error", 2, {
+      SwitchCase: 1,
+    }],
+
+    "no-trailing-spaces": "error",
+  },
+  ignores: [".nyc_output", "coverage", "node_modules"]
+}, {
+  files: ["**/*.md"],
+  processor: "markdown/markdown",
+}, {
+  files: ["**/*.md/*.js"],
+  plugins: {
+    markdown
+  },
+  extends: compat.extends("plugin:markdown/recommended")
+}
+]);

package.json

@@ -15,8 +15,10 @@
     "parseurl": "~1.3.3"
   },
   "devDependencies": {
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.27.0",
     "after": "0.8.2",
-    "eslint": "7.23.0",
+    "eslint": "^9.27.0",
     "eslint-plugin-markdown": "2.0.0",
     "mocha": "10.4.0",
     "nyc": "15.1.0",
@@ -33,8 +35,9 @@
   },
   "scripts": {
     "lint": "eslint .",
+    "lint:fix": "eslint --fix .",
     "test": "mocha --reporter spec --bail --check-leaks test/",
     "test-ci": "nyc --reporter=lcov --reporter=text npm test",
     "test-cov": "nyc --reporter=html --reporter=text npm test"
   }
-}
+}

test/test.js

@@ -11,6 +11,8 @@ var fixtures = path.join(__dirname, '/fixtures');
 var relative = path.relative(process.cwd(), fixtures);
 
 var skipRelative = ~relative.indexOf('..') || path.resolve(relative) === relative;
+var NODE_BASE_VERSION = 16;
+var major = process.versions.node.split('.')?.map(Number)?.[0] || NODE_BASE_VERSION;
 
 describe('serveIndex(root)', function () {
   it('should require root', function () {
@@ -86,13 +88,24 @@ describe('serveIndex(root)', function () {
       .expect(400, done)
   })
 
-  it('should deny path outside root', function (done) {
-    var server = createServer()
+  if (major < NODE_BASE_VERSION) {
+    /**
+     * For Node versions lower than 10. To keep retrocompatibility
+     *
+     * Inside serveIndex function, it uses path.normalize()
+     * When it receives the path '/../' the normalize function resolves it to '/'
+     * Therefore, this test will pass
+     *
+     * @see https://nodejs.org/download/release/v18.16.0/docs/api/path.html#pathnormalizepath
+     */
+    it('should deny path outside root', function (done) {
+      var server = createServer()
 
-    request(server)
-      .get('/../')
-      .expect(403, done)
-  })
+      request(server)
+        .get('/../')
+        .expect(403, done)
+    })
+  }
 
   it('should skip non-existent paths', function (done) {
     var server = createServer()
@@ -742,14 +755,25 @@ describe('serveIndex(root)', function () {
         .end(done)
     });
 
-    it('should not work for outside root', function (done) {
-      var server = createServer()
+    if (major < NODE_BASE_VERSION) {
+    /**
+     * For Node versions lower than 10. To keep retrocompatibility
+     *
+     * Inside serveIndex function, it uses path.normalize()
+     * When it receives the path '/../support/' the normalize function resolves it to '/support/'
+     * Therefore, this test will pass
+     *
+     * @see https://nodejs.org/download/release/v18.16.0/docs/api/path.html#pathnormalizepath
+     */
+      it('should not work for outside root', function (done) {
+        var server = createServer()
 
-      request(server)
-        .get('/../support/')
-        .set('Accept', 'text/html')
-        .expect(403, done)
-    });
+        request(server)
+          .get('/../support/')
+          .set('Accept', 'text/html')
+          .expect(403, done)
+      });
+    }
   });
 
   describe('when setting a custom stylesheet', function () {
@@ -807,12 +831,23 @@ describe('serveIndex(root)', function () {
         .expect(200, done)
     });
 
-    it('should not allow serving outside root', function (done) {
-      request(server)
-        .get('/../')
-        .set('Accept', 'text/html')
-        .expect(403, done)
-    });
+    if (major < NODE_BASE_VERSION) {
+      /**
+       * For Node versions lower than 10. To keep retrocompatibility
+       *
+       * Inside serveIndex function, it uses path.normalize()
+       * When it receives the path '/../' the normalize function resolves it to '/'
+       * Therefore, this test will pass
+       *
+       * @see https://nodejs.org/download/release/v18.16.0/docs/api/path.html#pathnormalizepath
+       */
+      it('should not allow serving outside root', function (done) {
+        request(server)
+          .get('/../')
+          .set('Accept', 'text/html')
+          .expect(403, done)
+      });
+    }
   });
 });