-
-
Notifications
You must be signed in to change notification settings - Fork 156
(test): fixing tests node v18 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test): fixing tests node v18 #118
Conversation
…id due newest nodejs verions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vagostep! I like to see how fast you started to do contributions ✨
I was thinking that we can keep the tests and just pass them when the Node.js version is major or equal to 18.16.0, so that way we don't lost these test for retrocompatibility. WDYT?
I changed the runner in 8cf1c4f so we can test this PR here directly 👍
Note: there are some linting issues too
I ran the test downgrading the Node version down to V16 and still the tests are failing. I'm going to try to identify since which version they started to fail
Checking it! |
…/vagostep/serve-index into AndresDiaz/fixing-tests-node-v18
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Hi guys. I just pushed new changes:
I could not find from which node version the test started to fail :/ without manually downgrade each package in the package.json to make them work. I only could test them until Node v16 and the test were still broken I'm open to suggestion about how can I proceed |
@@ -14,7 +14,7 @@ This is a [Node.js](https://nodejs.org/en/) module available through the | |||
[npm registry](https://www.npmjs.com/). Installation is done using the | |||
[`npm install` command](https://docs.npmjs.com/getting-started/installing-npm-packages-locally): | |||
|
|||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjohansebas linter continued marking me this line as error. I could not find a workaround
"after": "0.8.2", | ||
"eslint": "7.23.0", | ||
"eslint": "^9.27.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend not updating the linter yet, there's a broader discussion around it (see expressjs/discussions#327)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll revert it
closing in order to use #120 |
This PR solves #117
Tagging 3 tests as deprecated because, there are not longer valid.
the method path.normalize() will normalize them and, therefore, the expected scenarios are not going to happen anymore.
I could delete them, but first I would like your opinion.
Tested up to Node v22