Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building wheel in spacy package #6860

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Support building wheel in spacy package #6860

merged 2 commits into from
Jan 30, 2021

Conversation

ines
Copy link
Member

@ines ines commented Jan 30, 2021

Description

Allow spacy package to build binary wheels by introducing a unified --build option that defaults to sdist (but can also be set to wheel, sdist,wheel or none). Building the wheel will then run setup.py bdist_wheel under the hood.

Types of change

enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines added enhancement Feature requests and improvements feat / cli Feature: Command-line interface v3.0 Related to v3.0 labels Jan 30, 2021
@honnibal
Copy link
Member

Looks good! Go ahead and merge when ready :)

@ines ines merged commit b26a3da into develop Jan 30, 2021
@ines ines deleted the feature/package-wheel branch January 30, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / cli Feature: Command-line interface v3.0 Related to v3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants