Remove --no-cache-dir when downloading models #6857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
--no-cache-dir
is present, it prevents caching to properly function.If the user still wants to do this, there is the possibility to pass options with
user_pip_args
.But you should not enforce options like these. In my case this is preventing some docker build (using buildkit caching) to have proper caching of models.
Types of change
This PR removes the enforced
pip
options and leave this to the user.Checklist