Skip to content

Conversation

@rhiroe
Copy link
Contributor

@rhiroe rhiroe commented Jun 8, 2025

resolve #235

Allow openapi metadata specified in parent describe/context blocks to be inherited by child it blocks, eliminating the need to specify metadata on every individual test case.

@rhiroe rhiroe force-pushed the fix/Inherit-openapi-metadata branch 3 times, most recently from ff8a4e0 to 815cb11 Compare June 8, 2025 09:07
RSpec::OpenAPI.request_headers = %w[X-Authorization-Token]
RSpec::OpenAPI.response_headers = %w[X-Cursor]
RSpec::OpenAPI.path = File.expand_path("../apps/rails/doc/openapi.#{ENV.fetch('OPENAPI_OUTPUT', nil)}", __dir__)
RSpec::OpenAPI.path = File.expand_path("../apps/rails/doc/minitest_openapi.#{ENV.fetch('OPENAPI_OUTPUT', nil)}", __dir__)

Check notice

Code scanning / Rubocop

Checks that line length does not exceed the configured limit. Note test

Layout/LineLength: Line is too long. [121/120]
@codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (80c5b58) to head (b6f3575).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   97.13%   97.26%   +0.13%     
==========================================
  Files          20       20              
  Lines         628      658      +30     
  Branches      142      148       +6     
==========================================
+ Hits          610      640      +30     
  Misses         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhiroe rhiroe force-pushed the fix/Inherit-openapi-metadata branch from 815cb11 to 4a7fce6 Compare June 8, 2025 09:16
@rhiroe rhiroe changed the title WIP feat: inherit OpenAPI metadata from parent blocks to child blocks RSpec Jun 8, 2025
…RSpec

Allow openapi metadata specified in parent describe/context blocks to be
inherited by child it blocks, eliminating the need to specify metadata
on every individual test case.
@rhiroe rhiroe force-pushed the fix/Inherit-openapi-metadata branch from 4a7fce6 to b6f3575 Compare June 8, 2025 09:21
@rhiroe rhiroe changed the title feat: inherit OpenAPI metadata from parent blocks to child blocks RSpec feat: inherit OpenAPI metadata from parent blocks to child blocks in RSpec Jun 8, 2025
@rhiroe rhiroe marked this pull request as ready for review June 8, 2025 09:23
@exoego
Copy link
Owner

exoego commented Jun 8, 2025

LGTM
Thanks 🏆

@exoego exoego merged commit 099958e into exoego:master Jun 8, 2025
14 checks passed
@exoego exoego added the enhancement New feature or request label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customizations on an it-block completely remove customizations set on a parent describe

2 participants