Merge pull request #255 from rhiroe/fix/Inherit-openapi-metadata

Author: exoego

lib/rspec/openapi/extractors/hanami.rb

@@ -56,7 +56,7 @@ def request_attributes(request, example)
 
     return RSpec::OpenAPI::Extractors::Rack.request_attributes(request, example) unless route.routable?
 
-    metadata = example.metadata[:openapi] || {}
+    metadata = merge_openapi_metadata(example.metadata)
     summary = metadata[:summary] || RSpec::OpenAPI.summary_builder.call(example)
     tags = metadata[:tags] || RSpec::OpenAPI.tags_builder.call(example)
     formats = metadata[:formats] || RSpec::OpenAPI.formats_builder.curry.call(example)
@@ -100,6 +100,26 @@ def request_response(context)
     [request, response]
   end
 
+  private
+
+  def merge_openapi_metadata(metadata)
+    collect_openapi_metadata(metadata).reduce({}, &:merge)
+  end
+
+  def collect_openapi_metadata(metadata)
+    [].tap do |result|
+      current = metadata
+
+      while current
+        [current[:example_group], current].each do |meta|
+          result.unshift(meta[:openapi]) if meta&.dig(:openapi)
+        end
+
+        current = current[:parent_example_group]
+      end
+    end
+  end
+
   def add_id(path, route)
     return path if route.params.empty?
 

lib/rspec/openapi/extractors/rack.rb

@@ -6,7 +6,7 @@ class << RSpec::OpenAPI::Extractors::Rack = Object.new
   # @param [RSpec::Core::Example] example
   # @return Array
   def request_attributes(request, example)
-    metadata = example.metadata[:openapi] || {}
+    metadata = merge_openapi_metadata(example.metadata)
     summary = metadata[:summary] || RSpec::OpenAPI.summary_builder.call(example)
     tags = metadata[:tags] || RSpec::OpenAPI.tags_builder.call(example)
     formats = metadata[:formats] || RSpec::OpenAPI.formats_builder.curry.call(example)
@@ -40,4 +40,24 @@ def request_response(context)
 
     [request, response]
   end
+
+  private
+
+  def merge_openapi_metadata(metadata)
+    collect_openapi_metadata(metadata).reduce({}, &:merge)
+  end
+
+  def collect_openapi_metadata(metadata)
+    [].tap do |result|
+      current = metadata
+
+      while current
+        [current[:example_group], current].each do |meta|
+          result.unshift(meta[:openapi]) if meta&.dig(:openapi)
+        end
+
+        current = current[:parent_example_group]
+      end
+    end
+  end
 end

lib/rspec/openapi/extractors/rails.rb

@@ -16,7 +16,7 @@ def request_attributes(request, example)
 
     raise "No route matched for #{fixed_request.request_method} #{fixed_request.path_info}" if route.nil?
 
-    metadata = example.metadata[:openapi] || {}
+    metadata = merge_openapi_metadata(example.metadata)
     summary = metadata[:summary] || RSpec::OpenAPI.summary_builder.call(example)
     tags = metadata[:tags] || RSpec::OpenAPI.tags_builder.call(example)
     formats = metadata[:formats] || RSpec::OpenAPI.formats_builder.curry.call(example)
@@ -55,6 +55,26 @@ def request_response(context)
     [context.request, context.response]
   end
 
+  private
+
+  def merge_openapi_metadata(metadata)
+    collect_openapi_metadata(metadata).reduce({}, &:merge)
+  end
+
+  def collect_openapi_metadata(metadata)
+    [].tap do |result|
+      current = metadata
+
+      while current
+        [current[:example_group], current].each do |meta|
+          result.unshift(meta[:openapi]) if meta&.dig(:openapi)
+        end
+
+        current = current[:parent_example_group]
+      end
+    end
+  end
+
   # @param [ActionDispatch::Request] request
   def find_rails_route(request, app: Rails.application, path_prefix: '')
     app.routes.router.recognize(request) do |route, _parameters|

spec/apps/hanami/doc/openapi.json

@@ -496,7 +496,7 @@
     },
     "/tables": {
       "get": {
-        "summary": "index",
+        "summary": "Get a list of tables",
         "tags": [
           "Table"
         ],

spec/apps/hanami/doc/openapi.yaml

@@ -306,7 +306,7 @@ paths:
                 message: not found
   "/tables":
     get:
-      summary: index
+      summary: Get a list of tables
       tags:
       - Table
       parameters: