Add Theme Preferences Setting #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
reviewed
Apr 19, 2023
|
|
||
| # TODO: add these as default values in DB | ||
| def default_theme_preference | ||
| %i[eligible eligible_lifetime].include?(current_user.insiders_status) ? 'system' : 'light' |
There was a problem hiding this comment.
This should be active variants, not eligible variants. Check this in all your PRs pls
This was referenced May 3, 2023
iHiD
added a commit
that referenced
this pull request
May 3, 2023
* Update comment * Update some whites to bgcolorA, Create vars for progress bar dark theme, add color for `textColor2` * Track Overview, Syllabus, Exercises, About tweaks * Tracks, Exercises tweaks * Replacing values with variables whereever possible at Exercises, Tracks, Blogposts * Add darkmode styles to Mentoring * Disable any changes on site-header, site-footer * Representation tweaks, donation tweaks - WIP * Automation modal, Profile * Community page first pass * Community page swag border * Settings first pass * Impact, 12in23, track first pass * Fix one Ruby test * Replace couple 's with &apos and " * Add `mask-image` to concept-map * Fix a test * Add prefer-color-scheme default (#3477) * Add prefer-color-scheme default * Add another postcss plugin --------- Co-authored-by: dem4ron <demaaron88@gmail.com> * Add more filters, adjust colours on track show page, fix missing dark themes, setup media query for dark theme, fix logo colour, add unset colors from figma * Add track overview details, variables * Track about page details, correct variables, svg masking * Add more missing variables, fix misplaced ones * Concept-page modifications, updates * Fix HLJS theme-unset issue, add variables * Add variables to multiple svgs, align colors with filters * Change Logo colour * Fix filters, svg colours on about page * About pages modifications, fixes * Automation details, cursor color, tooltips - no dark mode, svgs * Add unset as modals default * Simplify variables, add missing variables * Add more filters and exceptions * Set purple filter to be the same in dark more * Fix journey page, notification element svgs * Add Theme Preferences Setting (#3696) * Set up * Add ThemeButtons * Change wording slightly * Tweaks * Update colors, add infomessages, set up buttons correctly * Add JS function to update theme pref * Simplify function * Update fn * Change boolean name to be more descriptive --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * change theme name * Site header, footer, tracks list, reduce number of variables * Tons of stuff * Many-many changes, fixes * Add more filters, alter some colours, change background for about pages here and there etc * Remove toggle button * More dark mode * Move concept line variables into colors.css, add better filter on concept icon on EDs, couple tweaks * Add variable for mastered concept backgorund * Completed heading * Add key * Add missing filters, make contrast better, tab colors, purple's dark variant, etc * Copy text color, removing backgrounds in darkmode, difficulty tags, more better contrasts * Change readonly hljs code background * Remove blocking filter * Patch up donate page * 12in23 * Adjustments, adding missing filters, etc * Turning card number color to grey now.. * Add accessibility-dark theme (#5331) * Remove duplicate method * Fix bullet issues * Disable selected theme selector (#5329) * Disable theme button, increase req limit, refactor * Remove form footer * Fixed test --------- Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual update:
For insiders:
For non-insiders:
Tooltip on hover: