-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark-mode #3437
Merged
Merged
Add dark-mode #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me, add color for `textColor2`
* Add prefer-color-scheme default * Add another postcss plugin --------- Co-authored-by: dem4ron <demaaron88@gmail.com>
… themes, setup media query for dark theme, fix logo colour, add unset colors from figma
…es here and there etc
…cept icon on EDs, couple tweaks
…ore better contrasts
* Disable theme button, increase req limit, refactor * Remove form footer * Fixed test --------- Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might need to go through this list again before merging - 21:47, Apr 28, 2023
Pick a dark variant for these:
#D85050
- Appears eg. in settings reset box#271B72
- Markdown inline codeblock#F2F0FC
- used on hover - Impact page/Stats box/first element#ECF2FF
- team page/"thousands of people" container backgroundNotes:
theme-(dark|light)
switchThings out of colour:
General:
Header
Footer
textColor2
and its dark-theme is a bright colour, looks not pleasant - pick a better dark-theme colour? - same issue at many other placesMaybe change it to textColor2's value?
Scrollbars
Markdown
c-textblock-header
backgroundc-textblock-content
background#271B72
- needs atheme-dark
colorDashboard:
textColor2
. Font colours are non-variablesTracks
Overview
Pretty OK overall
it is
#FFF3E1
- it doesn't have a dark-theme variant--new
has an--orange-filter
that has a dark-theme and becomes yellow, but the "New" text next to it doesn't have, nor does the background of the containerSyllabus
concept-map-line-available
is too brightExercises
Pretty good
About
Build
backgroundColorA
tracks/[track]
#page-track-show article
has a whiteish background that masks the whole page - needs to be a variable or deletedstats-box
has a white background - needs to be a variable or deletedc-ed
)tracks/[track]/exercises/[exercise]
textColor7
needs a filterupdate-bar
needs a dark colour backgroundbackgroundColorH
Overview
Pretty good overall
.concept
- outline glow is not suited for dark themeYour iterations
Also pretty good
Dig deeper
Community Solutions
Also pretty good
Mentoring
Looks really good
Approach -
show
, Blogpost, ArticleThe blog post itself is pretty good
Mentoring
Your workspace
Pretty good, don't see anything
Queue
textColor2
, requires a hover prop?Testimonials
Looks good. Like all modals, it has a separate
theme-dark
switchAutomation
mentoring/automation
text-primaryBtnBorder
needs to be replaced with the correct classPreview modal
This needs the most work so far - nothing is dark mode but the code block
Community-page
bg
needs to be a variableborder-b-6
's colour is offborderColor7
Donate
Public profile
Summary
c-contributions-summary
bg should be a variableContributions
Published solutions
Badges
Your journey
Pretty much good as it is
Keep in mind:
theme-dark
to the whole app will change the 'Your Journey' and some other texts that weren't meant to be changedSettings
Account settings
testimonial
,commonly-used
bg should be a variablePreferences, Communication Preferences
Donations
subscription-box
bgImpact page
bg-bgGray
Our team
Supporters
12in23