test-exercise: sed now more precisely excises #[ignore] #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395.
Previous implementation simply deleted all lines containing the string
[ignore]
. This was not desired behavior, because it also deletedlines which used the attribute inline.
The updated version now removes the string
#[ignore]
and anytrailing whitespace. If the line is blank in consequence, it deletes
the entire line; otherwise it leaves it.
Given test input:
the new sed line produces output:
If this is approved, it should be merged before #394 so that one can use the attribute inline.