perfect-numbers: Update tests from table-based to macro-based #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coriolinus
force-pushed
the
perfect-numbers-non-table-tests
branch
from
7abce35 to
04af43f
Compare
$ sh ./_test/count-ignores.sh
/home/travis/build/exercism/rust/exercises/perfect-numbers/tests/perfect-numbers.rs: Has 2 tests and 11 ignores (should be 1)
The command "sh ./_test/count-ignores.sh" exited with 1.Clearly, there will need to be some tooling updates if we decide to go this route. |
This PR is in response to exercism#392. Perfect-numbers currently uses table-based testing. For reasons outlined in exercism#392 (comment) I believe that table-based testing is not the appropriate way to do things. This is what macro-based tests might look like. Are they abstruse and opaque? Yes. However, they at least become individual tests, and I believe that this is _better than the status quo_.
coriolinus
force-pushed
the
perfect-numbers-non-table-tests
branch
from
2a17fc5 to
42e4d94
Compare
|
Given that there's been no discussion or objection in the last 6 days, I'll merge this once Travis approves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to #392; closes #392.
Perfect-numbers currently uses table-based testing. For reasons outlined
in #392 (comment)
I believe that table-based testing is not the appropriate way to do things.
This is what macro-based tests might look like. Are they abstruse and
opaque? Yes. However, they at least become individual tests, and I
believe that this is better than the status quo.