-
-
Notifications
You must be signed in to change notification settings - Fork 525
crypto-square: Reflect changes to problem specifications #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description was updated as part of https://github.com/exercism/problem-specifications/pull/929/files
10 tasks
This looks great, thanks @nholden I'll have a closer look at it when I can find some time in the next day or so. |
Just a heads up: I'll be off the grid for a bit, so if there are any requested changes to this PR, feel free to go ahead and make them without me if you'd like, or I'll be happy to loop back in early November. |
Thanks @nholden ❤️ |
ErikSchierboom
pushed a commit
to ErikSchierboom/ruby
that referenced
this pull request
Jan 15, 2021
* Strings concept exercise * Add strings concept exercise to the config.json * Add String manipulation phrase in the introduction * Rename class LogLine to module LogLineParser * Update languages/exercises/concept/strings/.docs/instructions.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Add Ruby implementation to the referece * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Improve after text Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
ErikSchierboom
pushed a commit
to ErikSchierboom/ruby
that referenced
this pull request
Jan 19, 2021
* Strings concept exercise * Add strings concept exercise to the config.json * Add String manipulation phrase in the introduction * Rename class LogLine to module LogLineParser * Update languages/exercises/concept/strings/.docs/instructions.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Add Ruby implementation to the referece * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Improve after text Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
ErikSchierboom
pushed a commit
to ErikSchierboom/ruby
that referenced
this pull request
Jan 19, 2021
* Strings concept exercise * Add strings concept exercise to the config.json * Add String manipulation phrase in the introduction * Rename class LogLine to module LogLineParser * Update languages/exercises/concept/strings/.docs/instructions.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Add Ruby implementation to the referece * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Improve after text Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
ErikSchierboom
pushed a commit
to ErikSchierboom/ruby
that referenced
this pull request
Jan 21, 2021
* Strings concept exercise * Add strings concept exercise to the config.json * Add String manipulation phrase in the introduction * Rename class LogLine to module LogLineParser * Update languages/exercises/concept/strings/.docs/instructions.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Add Ruby implementation to the referece * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Improve after text Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
ErikSchierboom
pushed a commit
to ErikSchierboom/ruby
that referenced
this pull request
Jan 26, 2021
* Strings concept exercise * Add strings concept exercise to the config.json * Add String manipulation phrase in the introduction * Rename class LogLine to module LogLineParser * Update languages/exercises/concept/strings/.docs/instructions.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Add Ruby implementation to the referece * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Improve after text Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
ErikSchierboom
pushed a commit
to ErikSchierboom/ruby
that referenced
this pull request
Jan 27, 2021
* Strings concept exercise * Add strings concept exercise to the config.json * Add String manipulation phrase in the introduction * Rename class LogLine to module LogLineParser * Update languages/exercises/concept/strings/.docs/instructions.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Add Ruby implementation to the referece * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Update languages/exercises/concept/strings/.docs/hints.md Co-Authored-By: Jeremy Walker <jez.walker@gmail.com> * Improve after text Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We recently made some changes to the crypto-square exercise over in exercism/problem-specifications to stop testing intermediate functions, fix inconsistencies in the description, and generally improve tests.
Bringing our tests and README inline with the new specifications would address #422, #545. Using a generator to do so would help us with our goal of generating all exercise tests.
What?
This PR:
How Has This Been Tested?
I ran the updated example solution against the newly generated tests and they passed.
Types of changes
References and Closures
Closes #422 and #545.
Checklist: