crypto-square: Fix description copy and example #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final example in the crypto-square description is inconsistent with the [source of the exercise](http://users.csc.calpoly.edu/~jdalbey/103/Projects/ProgrammingPractice.html), the canonical data, and with itself. This change does a few things to correct that: - While the encoding method is called a "square code," we're really dealing with all sorts of rectangles, squares included. The description gets this right up until the last example, and this change clarifies that. - In both the source of the exercise and the canonical data, when a "chunk" is shorter than the length of a row, a blank space is added to the end of that chunk. This change fixes that in the final example. - The copy before the final example says that "spaces should be distributed evenly across the last `n` rows," but it doesn't explain how. This change specifies that the spaces should be added to the end of each chunk. Here's a related discussion: #356
Insti
approved these changes
Oct 7, 2017
ErikSchierboom
approved these changes
Oct 7, 2017
|
Is there anything I can do to help get this and #937 merged? I'd like to resolve exercism/ruby#422, and it makes sense to have these two PRs merged before submitting a PR in the Ruby repo. |
|
2 approvals, no objections, I'll merge this. |
|
Done, thanks for the bump. |
|
Thanks, @Insti! 😄 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final example in the crypto-square description is inconsistent with the source of the exercise, the canonical data, and itself. This change does a few things to correct that:
While the encoding method is called a "square code," we're really dealing with all sorts of rectangles, squares included. The description gets this right up until the copy before the last example, and this change clarifies that.
In both the source of the exercise and the canonical data, when a "chunk" is shorter than the length of a row, a blank space is added to the end of that chunk. This change fixes that in the final example.
The copy before the final example says that "spaces should be distributed evenly across the last
nrows," but it doesn't explain how. This change specifies that the spaces should be added to the end of each chunk.Here's a related discussion: #356