Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/analyzer.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
EXERCISES = %w[
two_fer
acronym
leap
].freeze

FILENAMES = {
"acronym" => "acronym.rb",
"two-fer" => "two_fer.rb"
"two-fer" => "two_fer.rb",
"leap" => "leap.rb"
}.freeze

require 'mandate'
Expand Down
16 changes: 16 additions & 0 deletions lib/analyzers/leap/analyze.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module Leap
class Analyze < ExerciseAnalyzer
include Mandate

def analyze!
if solution.uses_std_lib?
self.status = :disapprove
self.comments = ["ruby.leap.std_lib"]
else
self.status = :refer_to_mentor
end

raise FinishedFlowControlException
end
end
end
19 changes: 19 additions & 0 deletions lib/analyzers/leap/representation.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module Leap
class Representation < SolutionRepresentation
def uses_std_lib?
date_node = SA::Helpers.extract_nodes(:const, target_method).find { |node| node.const_name == 'Date' }
return false if date_node.nil?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return false if date_node.nil?
return false unless date_node


date_node.parent.children.any? { |node| %i[leap? gregorian_leap? julian_leap?].include? node }
end

private
def target_module
SA::Helpers.extract_module_or_class(root_node, "Year")
end

def target_method
SA::Helpers.extract_module_method(target_module, "leap?")
end
end
end
59 changes: 59 additions & 0 deletions test/exercises/leap_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
require "test_helper"

class LeapTest < Minitest::Test
def test_date_leap_method_is_disapproved
source = <<~SOURCE
class Year
def self.leap?(year)
Date.leap?(year)
end
end
SOURCE

results = Leap::Analyze.(source)
assert_equal :disapprove, results[:status]
assert_equal ["ruby.leap.std_lib"], results[:comments]
end

def test_date_julian_leap_method_is_disapproved
source = <<~SOURCE
class Year
def self.leap?(year)
Date.julian_leap?(year)
end
end
SOURCE

results = Leap::Analyze.(source)
assert_equal :disapprove, results[:status]
assert_equal ["ruby.leap.std_lib"], results[:comments]
end

def test_date_gregorian_leap_method_is_disapproved
source = <<~SOURCE
class Year
def self.leap?(year)
Date.gregorian_leap?(year)
end
end
SOURCE

results = Leap::Analyze.(source)
assert_equal :disapprove, results[:status]
assert_equal ["ruby.leap.std_lib"], results[:comments]
end

def test_custom_implementation_referred_to_mentor
source = <<~SOURCE
class Year
def self.leap?(year)
year % 4 == 0
end
end
SOURCE

results = Leap::Analyze.(source)
assert_equal :refer_to_mentor, results[:status]
assert_empty results[:comments]
end
end