Add analyzer for leap exercise #105
Conversation
|
Re-opened as this has been pre-approved. |
|
Thanks, @SleeplessByte , just got notification from exercism/ruby#1532 (comment) So things seem to be connected properly. I was coming to reopen it as it is preapproved. |
PatrickMcSweeny
force-pushed
the
leap
branch
2 times, most recently
from
8a083b1 to
0a0a268
Compare
PatrickMcSweeny
force-pushed
the
leap
branch
2 times, most recently
from
fb2020b to
81997f1
Compare
| class Representation < SolutionRepresentation | ||
| def uses_std_lib? | ||
| date_node = SA::Helpers.extract_nodes(:const, target_method).find { |node| node.const_name == 'Date' } | ||
| return false if date_node.nil? |
There was a problem hiding this comment.
| return false if date_node.nil? | |
| return false unless date_node |
|
@SleeplessByte I think this is ready for review, as you are more familiar with the functionality of the analyzers (I have not looked at what it does nor the results for a long time). |
For ease of navigation, this means: https://github.com/exercism/website-copy/tree/main/analyzer-comments/ruby @PatrickMcSweeny you will need to address this, and please remember to link to relevant URI's such as the relevant forum post, and this PR and the issue created as well, so that things link up and is easy to get for folks reading and reviewing. |
|
Thanks @PatrickMcSweeny for working on this! |
3 participants
Closes exercism/ruby#1532