Skip to content

bowling: Make descriptions consistent #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Conversation

britto
Copy link
Contributor

@britto britto commented Jun 18, 2017

Make the usage of can not and cannot consistent throughout the file. Also add a missing more in one of the descriptions.

Since these changes are mostly cosmetic, I am not sure if a patch-level bump to the version key is required here. Please tell me if that is the case, so I can update it accordingly.

@petertseng
Copy link
Member

I am not sure if a patch-level bump to the version key is required here

yes because https://github.com/exercism/x-common#patch-version-changes says "Changing descriptions or comments." and this does that. no distinction is made whether they are cosmetic changes

these changes look good, thanks.

Make the usage of _can not_ and _cannot_ consistent throughout the file. Also add a missing `more` in one of the descriptions.
@britto
Copy link
Contributor Author

britto commented Jun 18, 2017

@petertseng awesome! done 👍.

@Insti Insti changed the title [Bowling] Fix case descriptions bowling: Fix case descriptions Jun 18, 2017
@Insti Insti changed the title bowling: Fix case descriptions bowling: Make descriptions consistent Jun 18, 2017
@stkent stkent merged commit 26e345e into exercism:master Jun 18, 2017
@stkent
Copy link
Contributor

stkent commented Jun 18, 2017

Nice changes, thanks!

@britto britto deleted the patch-1 branch June 18, 2017 15:39
kotp added a commit to exercism/ruby that referenced this pull request Aug 27, 2017
emcoding pushed a commit that referenced this pull request Nov 19, 2018
* affine-cipher: built generator; generated test; added BookKeeping to solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants