[Bowling] Update implementation and tests #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-breaking changes: * Sync all descriptions with their canonical counterparts. Possibly breaking changes: * Add a missing last-frame strike to one of the tests' data. * Add 4 new tests from the canonical repository. Breaking changes: * Update behavior for the scenario where a roll is made after the game is finished. * Update error messages to also match their canonical counterparts.
devonestes
approved these changes
Jun 19, 2017
There was a problem hiding this comment.
Given how minimal the breaking changes are (changing some error messages isn't a big deal), I'm cool with this. Thanks for the PR!
Since this does contain some breaking changes, I'm planning on leaving this open for another day or two in case anyone has any input they'd like to offer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes have been made to this problem since the last update: #416, #423, #444, #536 and more recently #832. My intention here is to reflect all those changes and also make the Elixir exercise as close to canonical as possible.
Non-breaking changes
Possibly breaking changes
two bonus rolls after a strike in the last frame cannot score more than 10 pointsBreaking changes
score, we break early onroll(see #536, this commit in particular).Pins must have a value from 0 to 10becomes eitherNegative roll is invalidorPin count exceeds pins on the lane.The reference solution has also been minimally updated to match the aforementioned changes.