Skip to content

Fix "Gigasecond: Schema Compliance" #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

kotp
Copy link
Member

@kotp kotp commented Mar 10, 2017

Reverts #679

@kotp
Copy link
Member Author

kotp commented Mar 10, 2017

ref: #625

@tejasbubane
Copy link
Member

I think we should do Fix Compliance instead of revert and then add new again.

@kotp kotp changed the title Revert "Gigasecond: Schema Compliance" Fix "Gigasecond: Schema Compliance" Mar 10, 2017
@kotp
Copy link
Member Author

kotp commented Mar 10, 2017

Yeah, but I think we can work from this one. This will mean less of a 'diff'.

@kotp kotp force-pushed the revert-679-gigasecond_make-exercise-schema-compliant branch from 9d6a664 to 61e7d70 Compare March 10, 2017 10:53
@kotp kotp requested a review from rbasso March 10, 2017 10:58
Copy link
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems absolutely perfect, @kotp!

@kotp kotp merged commit 3fb1fd7 into master Mar 10, 2017
@kotp
Copy link
Member Author

kotp commented Mar 10, 2017

Thanks @rbasso and @tejasbubane !

@kotp kotp deleted the revert-679-gigasecond_make-exercise-schema-compliant branch March 10, 2017 11:43
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants