Skip to content

Fixes the test generation for the etl task #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 0 additions & 192 deletions templates/etl/.broken

This file was deleted.

8 changes: 3 additions & 5 deletions templates/etl/test.ml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ let ae exp got _test_ctxt =

let tests = [
{{#cases}}
{{#cases}}
"{{description}}" >::
ae {{#input}}{{expected}}
({{property}} {{input}});{{/input}}
{{/cases}}
"{{description}}" >::
ae {{#input}}{{expected}}
({{property}} {{input}});{{/input}}
{{/cases}}
]

Expand Down
23 changes: 22 additions & 1 deletion test-generator/lib_generator/special_cases.ml
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,30 @@ let edit_grade_school_case (case: json): json =
]) input)
]) case

let edit_case ~(slug: string) (case: json) = match (slug, case) with
let edit_etl_case (case : Yojson.Basic.t) : Yojson.Basic.t =
let legacy_contents =
case
|> Util.member "input"
|> Util.member "legacy"
|> Util.to_assoc
|> fun l -> `Assoc l
in
let updated_case =
case
|> Util.to_assoc
|> List.map ~f:(fun (k, v) ->
if String.(k = "input") then (k, legacy_contents) else (k, v)
)
|> fun l -> `Assoc l
in
updated_case


let edit_case ~(slug: string) (case: json) =
match (slug, case) with
| ("allergies", case) -> edit_allergies_case case
| ("custom-set", case) -> edit_custom_set_case case
| ("etl", case) -> edit_etl_case case
| ("grade-school", case) -> edit_grade_school_case case
| ("difference-of-squares", case) -> edit_difference_of_squares_case case
| ("run-length-encoding", case) -> edit_run_length_encoding_case case
Expand Down