Skip to content

Fixes the test generation for the etl task #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasminenoack
Copy link

Addresses #468

This changed the parsing for etl to handle the new cannonical structure which looks like:

{
      "uuid": "78a7a9f9-4490-4a47-8ee9-5a38bb47d28f",
      "description": "single letter",
      "property": "transform",
      "input": {
        "legacy": {
          "1": ["A"]
        }
      },
      "expected": {
        "a": 1
      }
}

It removes the nested legacy key in the input section so that the json object for the case will match the expectations in the parser. The edit_etl_case returns the following pattern:

{
      "uuid": "78a7a9f9-4490-4a47-8ee9-5a38bb47d28f",
      "description": "single letter",
      "property": "transform",
      "input": {
        "1": ["A"]
      },
      "expected": {
        "a": 1
      }
}

Once the generator was working, I found an additional bug in the template that it was looping over the cases multiple times so I remove the inner loop so the 4 cases would only appear once. This appears to have been a copy/paste mistake from generators that do use nesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant