Skip to content

lint(track_config): check key feature icons #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

ErikSchierboom
Copy link
Member

This commit enables checking the key feature icons against the list of
allowed icons.

See also:

@ErikSchierboom ErikSchierboom requested a review from ee7 July 22, 2021 14:48
Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve and you can merge in the morning if ee7 doesn't get chance to look before then :)

This commit enables checking the key feature icons against the list of
allowed icons.

See also:
- exercism/docs#186, which defines the list of
  key feature icons
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ErikSchierboom ErikSchierboom merged commit 2e3ef6b into main Jul 23, 2021
@ErikSchierboom
Copy link
Member Author

@ee7 Care to build a new release?

@ee7
Copy link
Member

ee7 commented Jul 23, 2021

@ErikSchierboom Sure. #394

@ee7 ee7 deleted the key-feature-icons branch July 23, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants