forked from eXist-db/exist
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tumbling window #1
Open
gabriele-tomassetti
wants to merge
13
commits into
evolvedbinary:develop
Choose a base branch
from
Strumenta:feature/tumbling-window
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/tumbling window #1
gabriele-tomassetti
wants to merge
13
commits into
evolvedbinary:develop
from
Strumenta:feature/tumbling-window
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamretter
added a commit
that referenced
this pull request
Aug 25, 2022
…llection#0,#1 [feature] Implement the fn:uri-collection function
adamretter
pushed a commit
that referenced
this pull request
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1-2. Implement XQuery 3.1 Tumbling/Sliding Window expression
Description:
We have added support for Tumbling/Sliding Window expression (task 1-2), both in parsing and for the handling of intermediate AST.
In order to accomplish this task, we have added a new WindowExpr, that has WindowCondition fields.
Since, as stated in the Brief, you are willing to handle additional Java coding yourself, we have only added skeleton version of these classes. We have implemented just the necessary to test the parsing and AST creation. If this is not what you expected, let us know.
Some details regarding the implementation:
ForLetClause
with the newClauseType
,ClauseType.Window
ForLetClause
for Window Expression takes advantage of the field InputSequence inherited as aBindingExpression
. The same field that is present for a traditional For or Let Clause, but we add aWindowExpr
instead of aForExpr
in the Path expression. Let us know if this approach works for you or if you prefer to change itReference:
Reference
Type of tests:
We implemented a few tests in Java Code inside the file
WindowClauseTest.java
and . We have not implemented tests using XQSuite since they would require fully implement the aforementioned skeleton classes