Implement fn:path#0 and fn:path#1 #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizzzz
reviewed
May 23, 2022
|
|
||
| final StringBuilder value = new StringBuilder(); | ||
| final StringBuilder attributeValue = new StringBuilder(); | ||
| if (node.getNodeType() == Type.TEXT) { |
There was a problem hiding this comment.
a switch would be more correct here?
dizzzz
reviewed
May 23, 2022
| // its comment node siblings. | ||
| final int nodePosition = getNodePosition(node); | ||
| if (nodePosition > 0) { | ||
| value.append(String.format("/comment()[%d]", nodePosition)); |
There was a problem hiding this comment.
is the 1st position nodePosition 0 or 1 ?
does the XQTS not require /comment() (without indication) to be used iso /comment()[1] ?
There was a problem hiding this comment.
@dizzzz This is passing all XQTS tests for fn-path
dizzzz
reviewed
May 23, 2022
| // like-named processing-instruction node siblings. | ||
| final int nodePosition = getNodePosition(node); | ||
| if (nodePosition > 0) { | ||
| value.append(String.format("/processing-instruction(%s)[%d]", node.getNodeName(), nodePosition)); |
There was a problem hiding this comment.
@dizzzz This is passing all XQTS tests for fn-path
|
how to deal with #1463 ? It caused me to hold my PR.... |
|
@chris-evolvedbinary Also could you please use the prefixes in your commit messages. If you look at the commit log you will see we use prefixes like [bugfix], [feature], [test], [refactor], etc. |
adamretter
force-pushed
the
feature/fn-path#0,#1
branch
from
afd088f
to
68f8574
Compare
adamretter
force-pushed
the
feature/fn-path#0,#1
branch
from
68f8574
to
ec80946
Compare
|
SonarCloud Quality Gate failed. |
adamretter
approved these changes
Jun 15, 2022
12 tasks
joewiz
added a commit
to HistoryAtState/hsg-shell
that referenced
this pull request
Apr 25, 2024
Before eXist 6.1.0, eXist’s implementation of the fn:root() function contained a bug that caused it to always return a document node, even when called on an in-memory node whose root node was an element node. This bug was fixed in eXist-db/exist#4402. The only code in hsg-shell that assumed the buggy behavior was the code that handled the display of concurrent appointments in POCOM data. After upgrading HSG from 5.1.1 to 6.2.0, this code triggered an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
fn:path()function. This implementation requires fixing an issue with document nodes.Reference:
Type of tests:
exist-core/src/test/xquery/xquery3/fnPath.xqm--
This open source contribution to the eXist-db project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.