Restore vehicle onIdentify behavior for targetSoc from yaml #9685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naltatis
changed the title
@naltatis wollen wir den nicht einfach komplett reverten und dann nochmal in Ruhe alles glatt ziehen? |
|
Ahh, super! Dann rein damit? |
|
Wenn du das changeset kleiner haben möchtest kann ich die MinSoC Anpassungen raus nehmen. Da gehts vor allem um Klarheit. Die ändern kein Verhalten |
|
Ne, wenn das sogar beide Issue behebt ist super- gerne rein, DANKE! |
|
Ja, hab gerade noch mal ein paar Tests gemacht. Kann rein. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly reverts #9370 so that vehicle values from yaml are respected again.
A proper fix with UI configuration and new API endpoints here #9684
Restored behavior:
vehicle.targetSoc(onIdentify) will be used again@VolkerK62 Magst du die Doku anpassen https://docs.evcc.io/docs/reference/configuration/vehicles/#onidentify
Refactoring: yaml based
minSocsettings will not be used (as today). Structure is kept so that yaml files remain backwards compatible. Removed/clarified deprecation in the source code.