Planner: fix continuous plan execution #27227
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The newly added
requiredDuration > strategy.Preconditionchecks are repeated in multiple branches; consider extracting this into a named predicate or restructuring the switch to avoid duplication and make the intent clearer. - The added continuous-plan condition combines several time comparisons in a single
case; breaking this out into well-named intermediate variables (e.g.,wouldInterruptContinuous) or a helper function would improve readability and make the business rules easier to reason about. - For both the precondition-related checks and the continuous-plan condition, review whether strict
>vs>=behavior is intended at the thresholds, and consider documenting or encoding these boundary decisions explicitly to avoid subtle off-by-one timing issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The newly added `requiredDuration > strategy.Precondition` checks are repeated in multiple branches; consider extracting this into a named predicate or restructuring the switch to avoid duplication and make the intent clearer.
- The added continuous-plan condition combines several time comparisons in a single `case`; breaking this out into well-named intermediate variables (e.g., `wouldInterruptContinuous`) or a helper function would improve readability and make the business rules easier to reason about.
- For both the precondition-related checks and the continuous-plan condition, review whether strict `>` vs `>=` behavior is intended at the thresholds, and consider documenting or encoding these boundary decisions explicitly to avoid subtle off-by-one timing issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@andig it solves the issues reported for continuous planning. From my point of view we may go for it. Let's just discuss the open comment because it is relevant for non-continuous planning, would be valid to change in another PR probably |
iseeberg79
commented
Feb 6, 2026
andig
changed the title
Member
|
@iseeberg79 I guess this needs tests |
Contributor
Author
|
Very difficult to unit test, I tried but it got way to complicated |
This was referenced Feb 8, 2026
andig
reviewed
Feb 8, 2026
andig
reviewed
Feb 8, 2026
core/loadpoint_plan.go
Outdated
| case lp.clock.Until(planStart) < tariff.SlotDuration: | ||
| lp.log.DEBUG.Printf("plan: avoid re-start within %v, continuing for remaining %v", tariff.SlotDuration, lp.clock.Until(planStart).Round(time.Second)) | ||
| return true | ||
| case strategy.Continuous && requiredDuration > strategy.Precondition && planStart.After(lp.clock.Now()) && planStart.Before(planTime.Add(-requiredDuration-strategy.Precondition)): |
Member
There was a problem hiding this comment.
Does this need to be so complicated? The plan has already started- why check for plan start? Shouldn't this just be
case strategy.Continuous && requiredDuration > strategy.Precondition:
Contributor
Author
There was a problem hiding this comment.
ATM I believe we could skip a redundant, defensive planStart.After(lp.clock.Now()) but need to keep the additional condition having repeating plans in focus - I'll double-check this
Contributor
Author
There was a problem hiding this comment.
the reduced condition should be fine indeed. There are other checks guarding what I intended to check. I'll analyze a charging session in detail, it should be fine.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
strategy.Continuous && requiredDuration > strategy.Preconditioncase encodes a fairly specific behavioral rule; consider adding a short inline comment explaining why this condition is the right threshold to avoid interrupting continuous charging. - To make the new debug log more useful when diagnosing planner behavior, consider including
requiredDurationandstrategy.Preconditionvalues in the message alongside theplanStarttime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `strategy.Continuous && requiredDuration > strategy.Precondition` case encodes a fairly specific behavioral rule; consider adding a short inline comment explaining why this condition is the right threshold to avoid interrupting continuous charging.
- To make the new debug log more useful when diagnosing planner behavior, consider including `requiredDuration` and `strategy.Precondition` values in the message alongside the `planStart` time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
reviewed
Feb 8, 2026
Member
|
Rein damit? |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Ladevorgang erfolgreich: Start/Ziel und Precondition zum geplanten Zeitpunkt, Lademenge (Energie+SoC) zutreffend. Log Analyse ohne Auffälliges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27129
Testplan:
The debug logs for above charging sessions completed the last days show no unfortunate behavior.