Add property value spec for motor state #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WasabiFan
force-pushed
the
add-state-property-values
branch
from
361d59d to
3728eef
Compare
|
I think it should be fine, but I'm in the middle of updating the templates anyways - sorry I missed this notification, my spam filter was being a little aggressive the past few weeks :-) |
|
Feel free to finish the pull request, I'll update my local repo and fix up the Python binding as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rhempel Can you confirm that this won't break any of your templates?
stateis an array, so this is a new combination that hasn't been tested before (property values for an array).