Merged
Conversation
Contributor
Author
|
@derhuerst is this PR on the right track and if so how should I proceed? |
derhuerst
reviewed
Apr 28, 2021
Collaborator
derhuerst
left a comment
derhuerst
left a comment
There was a problem hiding this comment.
Looks good! Just some minor things.
emyarod
commented
Apr 29, 2021
|
hi @derhuerst! I'm wondering what's the timeline on cutting a release with this change? |
Collaborator
|
We're waiting on someone to publish a win32 binary, see #78. |
srubin
added a commit
to descriptinc/ffmpeg-ffprobe-static
that referenced
this pull request
Sep 15, 2023
* Update host for Windows binaries, closes eugeneware#60 * upgrade deps & dev deps * Travis CI: run install script manually 💚 * download win32-x64 binary from gyan.dev see also eugeneware#76 * fix linux-{x64,ia32,arm,arm64} binary downloads 💚 * fix binary publishing 💚 * add compressed binaries to GitHub release * install script: download gzipped binary ⚡️ closes eugeneware#69 * upgrade deps & dev deps * use 4.3.2 binaries, 4.2.8 fixes eugeneware#76 * support FreeBSD x64 closes eugeneware#75 * minor tweaks; 4.3.0 * readme.md/package.json: mention @Thefrank's FreeBSD builds [ci skip] * support darwin-arm64 eugeneware#80 * build script: pull ffmpeg 4.4 binaries * Add win32-ia32 build for 4.4 * fix FreeBSD x64 binary download 💚 * use 4.4 binaries; 4.4 * fix: upgrade eslint from 7.22.0 to 7.30.0 Snyk has created this PR to upgrade eslint from 7.22.0 to 7.30.0. See this package in npm: https://www.npmjs.com/package/eslint See this project in Snyk: https://app.snyk.io/org/derhuerst/project/cceee36c-4ce5-406d-8314-2573400ca9f6?utm_source=github&utm_medium=upgrade-pr * Use ffmpeg version 6.0 - Updates the version of ffmpeg from 4.4 to 6.0 - Fix the download URL based on https://github.com/eugeneware/ffmpeg-static/releases * Fix readme * Fix readme * adding updated package lockfile * fix install * Update release-binaries.yml * Update test.yml * build with newer node --------- Co-authored-by: TLZ <roesch.eric@protonmail.com> Co-authored-by: Jannis R <mail@jannisr.de> Co-authored-by: emyarod <emyarod@users.noreply.github.com> Co-authored-by: Max Isom <hi@maxisom.me> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: C Van Winkle <charles@descript.com> Co-authored-by: vyaas <vyaas@descript.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
running the build script seems to function as expected but I will need some help with regards to the cached releases and updating the relevant portions of the project README (is the ffmpeg version being bumped? etc). also unsure if curling the osxexperts page is sufficient for a
darwin-arm64.README