Skip to content

Conversation

fabianbl
Copy link
Contributor

@fabianbl fabianbl commented Feb 21, 2018

Reverting this for now as the link sometimes does not seem to work on Jenkins. The upstream fix is google/glog#188, which is applied in #24. Running autoreconf also seems to do the job (#19), so we should probably go with this fix for now and then update to glog 3.6 once it is available. Testing it on the TX2 today.

Update:
#19 works fine for both aarch64 and x86_64. I included the change in this PR (running autoreconf).

@fabianbl fabianbl requested a review from eggerk February 21, 2018 07:59
@fabianbl fabianbl requested a review from mfehr February 21, 2018 08:40
Copy link

@mfehr mfehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meyerj
Copy link

meyerj commented Feb 21, 2018

You might want to add <buildtool_depend>automake</buildtool_depend> to the package.xml file like in #24 to make sure that autoconf gets installed by tools like rosdep. It's typically not the case in a standard ROS environment, at least not on Ubuntu Desktop with ros-kinetic-desktop installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants