Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA-446 - DatahubConnector was not using token when configuring the ConnectionConfig/DatahubSchema #5762

Merged
merged 3 commits into from
Feb 14, 2025
+6 −3
Merged

HA-446 - DatahubConnector was not using token when configuring the ConnectionConfig/DatahubSchema #5762

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4394fc1
HA-446 - DatahubConnector was not using token when configuring the Co…
andres-torres-marroquin Feb 14, 2025
2d56b08
QA
andres-torres-marroquin Feb 14, 2025
e307df8
Merge branch 'main' into andres/HA-446
andres-torres-marroquin Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/fides/api/service/connectors/datahub_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Generic, Optional

from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
from datahub.ingestion.graph.client import DataHubGraph
from datahub.ingestion.graph.config import DatahubClientConfig
from loguru import logger

from fides.api.models.connectionconfig import ConnectionConfig, ConnectionTestStatus
Expand All @@ -15,9 +16,11 @@ class DatahubConnector(Generic[DB_CONNECTOR_TYPE]):
def __init__(self, configuration: ConnectionConfig):
self.configuration = configuration
self.config = DatahubSchema(**configuration.secrets or {})
# TODO: use token for authentication
self.datahub_client = DataHubGraph(
DataHubGraphConfig(server=str(self.config.datahub_server_url))
DatahubClientConfig(
server=str(self.config.datahub_server_url),
token=str(self.config.datahub_token),
)
)

def test_connection(self) -> Optional[ConnectionTestStatus]:
Expand Down
Loading