Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA-446 - DatahubConnector was not using token when configuring the ConnectionConfig/DatahubSchema #5762

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Feb 14, 2025

Closes HA-446

Description Of Changes

DatahubConnector was not using token when configuring the ConnectionConfig/DatahubSchema

Code Changes

  • Updates to DatahubConnector

Steps to Confirm

  1. Configure a Datahub integration that requires token.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 4:54pm

@andres-torres-marroquin andres-torres-marroquin merged commit b4dc5bb into main Feb 14, 2025
15 of 16 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HA-446 branch February 14, 2025 16:54
andres-torres-marroquin added a commit that referenced this pull request Feb 14, 2025
Copy link

cypress bot commented Feb 14, 2025

fides    Run #12482

Run Properties:  status check passed Passed #12482  •  git commit b4dc5bb62f: HA-446 - DatahubConnector was not using token when configuring the ConnectionCon...
Project fides
Branch Review main
Run status status check passed Passed #12482
Run duration 00m 49s
Commit git commit b4dc5bb62f: HA-446 - DatahubConnector was not using token when configuring the ConnectionCon...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.20%. Comparing base (a337457) to head (e307df8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5762   +/-   ##
=======================================
  Coverage   87.19%   87.20%           
=======================================
  Files         391      391           
  Lines       24312    24313    +1     
  Branches     2632     2632           
=======================================
+ Hits        21200    21201    +1     
  Misses       2537     2537           
  Partials      575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants