Skip to content

fix(postage): prevent nil pointer panic in TopUpBatch on transaction … #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akrem-chabchoub wants to merge 4 commits into
base: master
Choose a base branch
from
+4 −3
Open

fix(postage): prevent nil pointer panic in TopUpBatch on transaction … #5332

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
690dcba
fix(postage): prevent nil pointer panic in TopUpBatch on transaction …
akrem-chabchoub Jan 25, 2026
ad373aa
fix(postage): remove whitespace
akrem-chabchoub Jan 25, 2026
8de5abf
fix(postage): remove unused txHash assignment in TopUpBatch function
akrem-chabchoub Jan 26, 2026
4d4051e
fix(postage): restore txHash assignment in CreateBatch and DiluteBatc…
akrem-chabchoub Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/postage/postagecontract/contract.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ func (c *postageContract) CreateBatch(ctx context.Context, initialBalance *big.I
if err != nil {
return
}
txHash = receipt.TxHash

for _, ev := range receipt.Logs {
if ev.Address == c.postageStampContractAddress && len(ev.Topics) > 0 && ev.Topics[0] == c.batchCreatedTopic {
var createdEvent batchCreatedEvent
Expand All @@ -415,6 +415,7 @@ func (c *postageContract) CreateBatch(ctx context.Context, initialBalance *big.I
if err != nil {
return
}
txHash = receipt.TxHash
return
}
}
Expand Down Expand Up @@ -447,7 +448,6 @@ func (c *postageContract) TopUpBatch(ctx context.Context, batchID []byte, topupB

receipt, err := c.sendTopUpBatchTransaction(ctx, batch.ID, topupBalance)
if err != nil {
txHash = receipt.TxHash
Copy link
Member

@gacevicljubisa gacevicljubisa Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is obvious panic, if error happens, receipt is nil

return
}

Expand Down Expand Up @@ -483,9 +483,10 @@ func (c *postageContract) DiluteBatch(ctx context.Context, batchID []byte, newDe
if err != nil {
return
}
txHash = receipt.TxHash

for _, ev := range receipt.Logs {
if ev.Address == c.postageStampContractAddress && len(ev.Topics) > 0 && ev.Topics[0] == c.batchDepthIncreaseTopic {
txHash = receipt.TxHash
return
}
}
Expand Down
Loading