-
Notifications
You must be signed in to change notification settings - Fork 382
fix(postage): prevent nil pointer panic in TopUpBatch on transaction … #5332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akrem-chabchoub
wants to merge
4
commits into
master
Choose a base branch
from
fix/postage-contract-panic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1a5628 to
ad373aa
Compare
martinconic
reviewed
Jan 26, 2026
martinconic
approved these changes
Jan 26, 2026
gacevicljubisa
approved these changes
Jan 29, 2026
gacevicljubisa
approved these changes
Jan 29, 2026
|
|
||
| receipt, err := c.sendTopUpBatchTransaction(ctx, batch.ID, topupBalance) | ||
| if err != nil { | ||
| txHash = receipt.TxHash |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is obvious panic, if error happens, receipt is nil
Member
|
Also, we should return txHash only in case that there is no error: so we should adapt for CreateBatch and DiluteBatch Also, it would be good if this is covered in unit tests as well. |
janos
approved these changes
Jan 29, 2026
gacevicljubisa
approved these changes
Jan 29, 2026
martinconic
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Before when running this command you will get panic error, now with the fix:
curl -s -X PATCH "http://localhost:1640/stamps/topup/{BATCH_ID}/2" \ -H "Gas-Price: 10"Config:
Logs:
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):