Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint Dependency #2914

Merged
merged 9 commits into from
Jul 26, 2023
Merged

Update ESLint Dependency #2914

merged 9 commits into from
Jul 26, 2023

Conversation

scorbajio
Copy link
Contributor

No description provided.

@scorbajio scorbajio linked an issue Jul 23, 2023 that may be closed by this pull request
Update ESLint Dependency #2905
Closed
@codecov
Copy link

codecov bot commented Jul 23, 2023 •
edited
Loading

Codecov Report

Merging #2914 (1094e98) into master (38de29b) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <ø> (ø)
blockchain 92.58% <ø> (ø)
client 88.39% <ø> (+0.09%) ⬆️
common 98.64% <ø> (ø)
ethash ∅ <ø> (∅)
evm 69.95% <ø> (ø)
rlp ∅ <ø> (?)
statemanager 85.16% <ø> (ø)
trie 90.25% <ø> (-0.70%) ⬇️
tx 95.96% <ø> (ø)
util 86.77% <ø> (ø)
vm 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you check all the eslint plugins too?

acolytec3
acolytec3 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@acolytec3 acolytec3 merged commit 191faf5 into master Jul 26, 2023
41 checks passed
@holgerd77 holgerd77 deleted the update-eslint branch July 31, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: monorepo PR state: needs review type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ESLint Dependency
2 participants
@scorbajio @acolytec3