Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint Dependency #2905

Closed
holgerd77 opened this issue Jul 20, 2023 · 1 comment · Fixed by #2914
Closed

Update ESLint Dependency #2905

holgerd77 opened this issue Jul 20, 2023 · 1 comment · Fixed by #2914

Comments

@holgerd77
Copy link
Member

Our ESlint dependency is pinned to 8.22.0 (see root package.json file). This release is from roughly a year ago (August 2022, see release page) and so this is already pretty outdated and there have been various releases in between up to v8.45.0.

So we should update here, also the associated plugin versions since there have been a lot of bug fixes along the road.

I think it is likely that linting stuff will break along the road and it might therefore be wise to take this on a bit slowly and go step-by-step here and e.g. only go up 5 or so versions (and also do the plugins separately) and then run GitHub CI and see if things still work or otherwise fix linting. Then one can likely better associate what update made things break.

grafik
@holgerd77
Copy link
Member Author

Side note: there is currently a parsing error shown like below in the different .eslintrc.cjs config files in the packages folders:

grafik

This can be solved by adding '.eslintrc.cjs' to the ignorePatters in config/eslint.cjs.

Maybe this can be added on the sideline here, wouldn't want to open a dedicated PR and trigger CI just for this one-line change.

@scorbajio scorbajio linked a pull request Jul 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant