-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block, VM: Unify hardforkBy Options #2800
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be missing the significance but requested one change in how we evaluate the setHardfork
opt so we don't check it twice (if it's indeed true
). Small efficiency gain if I'm not missing something. Otherwise, looks great!
Co-authored-by: acolytec3 <konjou@gmail.com>
@jochem-brouwer @acolytec3 thanks for reviewing 🙂, have applied the suggested changes, needs re-approval now! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, good catch @acolytec3. LGTM still! 😄 (assuming CI passes)
Nvm, CI fails. I should not approve so fast 😅 (how do I dismiss my review?) |
Will re-approve if CI passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing! 🚀 ❤️
Changes are adressed, will dismiss.
Second part of #2774 following #2798
This PR does the following:
hardforkByBlockNumber
,hardforkByTTD
options ->setHardfork
hardforkByBlockNumber
,hardforkByTTD
options ->setHardfork