-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common: Unify and Refactor set-/getHardforkByBlockNumber #2798
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approving yet as I'm reviewing this on mobile and CI is still running so want to take a second look later this morning but this looks great so far! Much more common
sense approach so far.
A great first start on reducing confusion on how we do this! |
Partly solves #2774
This PR does the following:
Common.getHardforkByBlockNumber()
->Common.getHardforkBy()
(+ strict bigint types)Common.setHardforkByBlockNumber()
->Common.setHardforkBy()
(+ strict bigint types)Blockchain.checkAndTransitionHardForkByNumber()
BigIntLike -> strict bigint types