Develop-v7 merged with master commits #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, remove npm v7 check (#2644)
* Draft various release notes * CHANGELOG updates * Version bump, updated upstream dependency versions, @ethereumjs/util v8.0.6 * Version bump, updated upstream dependency versions, @ethereumjs/common v3.1.2 * Version bump, updated upstream dependency versions, @ethereumjs/tx v4.1.2 * Version bump, updated upstream dependency versions, @ethereumjs/trie v5.0.5 * Add additional @chainsafe/ssz notes to CHANGELOG files of other libraries * Version bump, updated upstream dependency versions, updated (all) client @ethereumjs dependencies, @ethereumjs/devp2p v5.1.2 * Version bump, updated upstream dependency versions, @ethereumjs/statemanager v1.0.5 * Version bump, updated upstream dependency versions, @ethereumjs/block v4.2.2 * Version bump, updated upstream dependency versions, @ethereumjs/ethash v2.0.5 * Version bump, updated upstream dependency versions, @ethereumjs/blockchain v6.2.2 * Version bump, updated upstream dependency versions, @ethereumjs/evm v1.3.2 * Version bump, updated upstream dependency versions, @ethereumjs/vm v6.4.2 * Version bump, @ethereumjs/client v0.7.1 * Rebuild package-lock.json * Rebuild relevant documentation * Updated @chainsafe/ssz related CHANGELOG entries
When preparing Ethereum data for RLP encoding, you must convert all values to either byte arrays or lists. Scalar values (positive integers) are converted to byte arrays by using the fewest bytes possible to represent the value in big endian format. The canonical form of any scalar value prepped for RLP encoding is that any leading `0` bytes stripped. In the case of `0`, this means that the only byte (`0x00`) is stripped and you are left with an empty array. Most of the values in this code are properly 0-stripped using `bigIntToUnpaddedBuffer`. Unfortunately, it appears that the `chainId` was added without stripping leading zeros. In most cases this doesn't matter, but if someone is running a chainId 0 blockchain and they want to EIP-155 encode their transaction, the previous code would result in an invalid transaction because only the canonical form is allowed. This change fixes this bug and correctly prepares the chainId in EIP-155 transactions for RLP encoding.
* Monorepo: remove dynamic external node version check, statically set to 16,18,20 * Remove get-node-versions entirely * Remove pull request trigger --------- Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cherrypicked all of the commits from
masterthat weren't included indevelop-v7into this branch. This PR is to give us a view on the diff and see if there's anything I missed or any tests failing due to bad merge commit fixes.