Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trie: update references to old deleteFromDB constructor arg #2695

Merged
merged 1 commit into from
May 11, 2023

Conversation

gabrocheleau
Copy link
Contributor

This PR updates old references to the deleteFromDB trie constructor arg, which was replaced in favour of useNodePruning in #2203

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2695 (146c3df) into master (404054b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.18% <ø> (ø)
blockchain 90.40% <ø> (ø)
client 87.12% <ø> (ø)
common 95.74% <ø> (ø)
devp2p 91.81% <ø> (-0.11%) ⬇️
ethash ∅ <ø> (∅)
evm 79.39% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (ø)
tx 94.43% <ø> (ø)
util 85.19% <ø> (ø)
vm 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acolytec3 acolytec3 merged commit bd85ada into master May 11, 2023
@holgerd77 holgerd77 deleted the trie/update-deleteFromDb-remnants branch June 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants