Ensuring UTF-8 encoding for MSVC builds

[shellygr]

Reopened from #5870

[axic]

Re. your question - it's VS2017. Not sure this option existed before that.

Does that mean it will fail on earlier compilers? We do compile with VS2015, but automation is of Appveyor is not turned on for fork PRs.

[shellygr]

Isn't VS2017 a prerequisite according to the Solidity install guide?
In any case it should be fine though -
According to https://docs.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=vs-2015
this option did exist in VS2015.

[axic]

Isn't VS2017 a prerequisite according to the Solidity install guide?

Sorry, you are correct, support was dropped in 0.5.2 (#5669).

[codecov]

Codecov Report

Merging #5871 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5871   +/-   ##
========================================
  Coverage    88.36%   88.36%           
========================================
  Files          349      349           
  Lines        33446    33446           
  Branches      4006     4006           
========================================
  Hits         29553    29553           
  Misses        2535     2535           
  Partials      1358     1358

Flag	Coverage Δ
#all	88.36% <ø> (ø)	⬆️
#syntax	28.32% <ø> (ø)	⬆️

[chfast]

Ok to me.

[axic]

@shellygr thanks!

[shellygr]

@axic and thank you for the the swift handling and the education!