Ensuring UTF-8 encoding for MSVC builds #5870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jan 26, 2019
Codecov Report
@@ Coverage Diff @@
## develop #5870 +/- ##
========================================
Coverage 88.36% 88.36%
========================================
Files 349 349
Lines 33446 33446
Branches 4006 4006
========================================
Hits 29553 29553
Misses 2535 2535
Partials 1358 1358
|
|
@shellygr thanks, can you squash the commits into one? What MSVC versions did required this flag? |
|
Since it's a one line change I'll close this pull request and open another one. |
|
If you create PRs from branches it is usually easier to squash/rebase/.. work with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for different locales in WIN compilation by setting /utf-8 flag in MSVC.
Build may otherwise fail with errors such as:
solidity\test\libdevcore\utf8.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (1255). Save the file in Unicode format to prevent data loss