-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Merge develop into release for 0.5.3. #5836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set version to 0.5.3
Merge release back into develop.
…ing that this is a C++ project. CMake defaults to C *and* C++ toolchain, in case nothing has been specified. This means that cmake always checks for both, which is more than needed. This PR cuts off C toolchain requirement from /CMakeLists.txt and ensures that we don't pass along any `..._C_...` variables in EthCompilerSettings.cake nor jsoncpp.cmake.
DOCS: Remove comments FAQ item
DOCS: Remove Structs item from FAQ
- create contributor list earlier - fix name of bytecode comparison directory - add instructions to upload the source tarball
Update release checklist.
CMake: Use toolchain files
cmake: Do not depend on a C compiler to be present
[cmdline tests] Select only directories to skip the readme
Happy New Year !! 🎇 Copyright year udated to 2019.
In install_deps.sh, line 59 (sed -n -e 's/^NAME="?([^"])"?$/\1/p' /etc/os-release) will get CentOS Linux instead of CentOS, so it cant match CentOS. I suggest that in line 355, can modified " CentOS)" to " CentOS*)"
Update install_deps.sh
copyright year updated
[DOC] More details about packed encoding.
Remove boost workarounds
improve packed encoding test vector
[DOCS] Remove copy between contracts FAQ item
Disallow calldata structs.
[SMTChecker] Support basic typecast without truncation
[DOCS] Further clarify in-memory arrays
Update to emscripten 1.38.22
[DOCS] Merge payable FAQ item
[SMTChecker] Clear state knowledge after external function calls
Patch soljson.js to provide backwards compatibility with older emscripten versions.
[REF] Provide ABI encoding options as single struct parameter.
Update changelog for release.
Use v0.5.0 tag of solc-js repository for external tests.
Codecov Report
@@ Coverage Diff @@
## release #5836 +/- ##
==========================================
Coverage ? 28.32%
==========================================
Files ? 348
Lines ? 33248
Branches ? 4005
==========================================
Hits ? 9419
Misses ? 23141
Partials ? 688
|
Move warning Updates from feedback Link to security note and fix link rendering Move solution to security docs and turn warning to a warning
[DOCS] Move FAQ item about truncation checks
axic
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.