Skip to content

[SMTChecker] Clear state knowledge after external function calls #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

[SMTChecker] Clear state knowledge after external function calls #5718

merged 1 commit into from
Jan 21, 2019

Conversation

leonardoalt
Copy link
Member

@leonardoalt leonardoalt commented Dec 20, 2018 •
edited
Loading

Fixes #5190

chriseth
chriseth suggested changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@chriseth chriseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that shows that mappings (also local variables referring to state variables) are properly reset.

@leonardoalt leonardoalt force-pushed the smt_external_functions branch from 06c9d35 to 351230c Compare January 15, 2019 17:38
@codecov
Copy link

codecov bot commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #5718 into develop will decrease coverage by 0.1%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5718      +/-   ##
===========================================
- Coverage    88.35%   88.25%   -0.11%     
===========================================
  Files          348      347       -1     
  Lines        33408    33153     -255     
  Branches      4003     3981      -22     
===========================================
- Hits         29519    29258     -261     
- Misses        2533     2537       +4     
- Partials      1356     1358       +2
Flag Coverage Δ
#all 88.25% <93.33%> (-0.11%) ⬇️
#syntax 28.24% <0%> (-0.11%) ⬇️

@leonardoalt
Copy link
Member Author

@chriseth Added tests

@leonardoalt leonardoalt force-pushed the smt_external_functions branch from 351230c to 6858fd3 Compare January 16, 2019 10:17
chriseth
chriseth reviewed Jan 16, 2019
View reviewed changes
chriseth
chriseth suggested changes Jan 16, 2019
View reviewed changes
@leonardoalt leonardoalt force-pushed the smt_external_functions branch 2 times, most recently from 4c08942 to 506f0b5 Compare January 16, 2019 15:58
@chriseth
Copy link
Contributor

Needs rebase.

@leonardoalt leonardoalt force-pushed the smt_external_functions branch from 506f0b5 to 7f8ceaa Compare January 21, 2019 11:59
@chriseth chriseth merged commit 05b0d32 into develop Jan 21, 2019
@axic axic deleted the smt_external_functions branch January 21, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonardoalt @chriseth