[Yul] Split constants too #5206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
splitConstantsToo
branch
from
f25c0d1 to
1e06422
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5206 +/- ##
========================================
Coverage 87.88% 87.88%
========================================
Files 313 313
Lines 31819 31819
Branches 3783 3782 -1
========================================
Hits 27965 27965
Misses 2572 2572
Partials 1282 1282
|
leonardoalt
reviewed
Oct 12, 2018
| // if _2 | ||
| // let _1 := 0 | ||
| // let x := calldataload(_1) | ||
| // let _2 := 3 |
There was a problem hiding this comment.
Why does this show before := 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the expression splitter to also extract constants.
Required for #5147