Skip to content

[Yul] Simplifier via broken #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2018
Merged

[Yul] Simplifier via broken #5147

merged 3 commits into from
Oct 16, 2018

Conversation

chriseth
Copy link
Contributor

@chriseth chriseth commented Oct 5, 2018 •
edited
Loading

Closes #4946

@chriseth chriseth force-pushed the simplifierViaBroken branch 2 times, most recently from dc96c71 to d4ac480 Compare October 11, 2018 19:20
@codecov
Copy link

codecov bot commented Oct 11, 2018 •
edited
Loading

Codecov Report

Merging #5147 into develop will decrease coverage by 0.03%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5147      +/-   ##
===========================================
- Coverage    87.92%   87.89%   -0.04%     
===========================================
  Files          317      319       +2     
  Lines        32024    32060      +36     
  Branches      3827     3830       +3     
===========================================
+ Hits         28158    28178      +20     
- Misses        2566     2583      +17     
+ Partials      1300     1299       -1
Flag Coverage Δ
#all 87.89% <93.75%> (-0.04%) ⬇️
#syntax 28.26% <0%> (-0.04%) ⬇️

@chriseth chriseth mentioned this pull request Oct 11, 2018
Merged
@chriseth chriseth changed the title [WIP] Simplifier via broken [Yul] Simplifier via broken Oct 11, 2018
@chriseth chriseth force-pushed the simplifierViaBroken branch 4 times, most recently from cc11183 to af86b64 Compare October 15, 2018 10:33
@chriseth
Copy link
Contributor Author

Rebased.

@chriseth chriseth force-pushed the simplifierViaBroken branch from af86b64 to 4254de9 Compare October 15, 2018 17:52
leonardoalt
leonardoalt reviewed Oct 16, 2018
View reviewed changes
libyul/optimiser/SSAValueTracker.cpp Outdated
@@ -0,0 +1,53 @@
/*(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo (

leonardoalt
leonardoalt reviewed Oct 16, 2018
View reviewed changes
libyul/optimiser/SSAValueTracker.cpp Outdated
assertThrow(
m_values.count(_name) == 0,
OptimizerException,
"Source needs to be disamiguated."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo disamiguated

@chriseth chriseth force-pushed the simplifierViaBroken branch from 4254de9 to ffe4453 Compare October 16, 2018 14:18
@chriseth chriseth merged commit 72b1bb0 into develop Oct 16, 2018
@chriseth chriseth deleted the simplifierViaBroken branch November 13, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoalt leonardoalt leonardoalt approved these changes

@christianparpart christianparpart Awaiting requested review from christianparpart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriseth @leonardoalt